Update uhtml dependencies and logic#908
Update uhtml dependencies and logic#908krausest merged 1 commit intokrausest:masterfrom WebReflection:uhtml
Conversation
|
@krausest apologies for the late reply. As the whole benchmark is based on a single id (one selected row per time, never more) the select row logic has been moved into "implementation detail", like it is for a few others libraries. The shared/common helper logic that drives the benchmark logic won't "move the world" on row selection changes. I don't know if this needs to be flagged somehow, but 801 is gone (although I forgot to update the non-keyed bench too). Happy to provide more details, if needed, and thanks for the merge. Non keyed might come soon too. |
|
@krausest @WebReflection it looks like this implementation should be moved into #772 category, based on code from its dependency: Also, I feel that moving whole benchmark implementation into current repository will ease further reviews, without need to manually scan through each dependency for the actual code. |
|
I didn't pick up on that. That repo of utils especially select row is clearly #772. It's hidden from the in repo implementation but it is also not library internals and clearly is tailored for the benchmark. It stashes the DOM element and toggles the classList directly with "danger". |
Various libraries of mine use that very same dependency, but in more than one occasion I've stated that we should have shared benchmark logic across libraries so that all have the same underlying performance, and we'll measure, at that point, only libraries overhead. I am OK with the #772 flag though, as I've already mentioned before.
This benchmark does not allow multiple rows selection, so that looping through all of them makes no sense. Previous versions are still within the uhtml folder. |

This MR applies the following changes:
Thanks for considering this MR 👋